chrome/browser/safe_browsing/malware_details.cc - Issue 12227003: Don't add invalid URLs to MalwareDetails resources_ map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/malware_details.cc

Issue 12227003: Don't add invalid URLs to MalwareDetails resources_ map. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/malware_details.cc

diff --git a/chrome/browser/safe_browsing/malware_details.cc b/chrome/browser/safe_browsing/malware_details.cc

index 7d7daa223212c1f4b2c0070e3974ca3e40a46a13..d615730d687d2dfbac5847de2eaf55d751c1f20e 100644

--- a/chrome/browser/safe_browsing/malware_details.cc

+++ b/chrome/browser/safe_browsing/malware_details.cc

@@ -129,7 +129,7 @@ void MalwareDetails::AddUrl(const GURL& url,

const GURL& parent,

const std::string& tagname,

const std::vector<GURL>* children) {

- if (!IsPublicUrl(url))

+ if (!url.is_valid() || !IsPublicUrl(url))

return;

// Find (or create) the resource for the url.

« no previous file with comments | « no previous file | no next file » | no next file with comments »