Issue 12226137: Fix missing callback chaining in UsbService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12226137: Fix missing callback chaining in UsbService. (Closed)

Created:
7 years, 10 months ago by Garret Kelly

Modified:
7 years, 10 months ago

Reviewers:
miket_OOO, bryeung, asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix missing callback chaining in UsbService. On OS_CHROMEOS when the permission_broker checks a set of devices the UsbService needs to wait for the async work to complete before responding. This worked on OS_CHROMEOS desktop builds because the stub implementation of PermissionBrokerClient wasn't racing to modify the devices vector. BUG=chromium-os:38836 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182320

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -17 lines)			Patch
M	chrome/browser/extensions/api/usb/usb_api.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/usb/usb_api.cc	View	3 chunks	+14 lines, -11 lines	0 comments	Download
M	chrome/browser/usb/usb_service.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/usb/usb_service.cc	View	1 chunk	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Garret Kelly

bryeung, for chrome/browser/usb miket || asargent, for chrome/browser/extensions

7 years, 10 months ago (2013-02-13 05:39:19 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gdk@chromium.org/12226137/1

7 years, 10 months ago (2013-02-13 18:53:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gdk@chromium.org/12226137/1

7 years, 10 months ago (2013-02-13 19:38:14 UTC) #5

Message was sent while issue was closed.

Change committed as 182320

Expand Messages | Collapse Messages