Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 12226100: Fix crash in ExtensionUninstallDialogView. It needs to verify Shell (Closed)

Created:
7 years, 10 months ago by sky
Modified:
7 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, Aaron Boodman, tfarina, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Fix crash in ExtensionUninstallDialogView. It needs to verify Shell exists before invoking method on it. BUG=174872 TEST=none R=xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181894

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
7 years, 10 months ago (2013-02-11 23:26:32 UTC) #1
xiyuan
lgtm
7 years, 10 months ago (2013-02-11 23:30:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/12226100/1
7 years, 10 months ago (2013-02-12 00:42:09 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 06:56:01 UTC) #4
Message was sent while issue was closed.
Change committed as 181894

Powered by Google App Engine
This is Rietveld 408576698