Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12226073: Implement GenerateInitiateUpload{New,Existing}FileUrl. (Closed)

Created:
7 years, 10 months ago by hidehiko
Modified:
7 years, 10 months ago
Reviewers:
hashimoto, satorux1, kinaba
CC:
chromium-reviews, achuith+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@b148632_split_initiate_upload_interface
Visibility:
Public.

Description

Implement GenerateInitiateUpload{New,Existing}FileUrl. This is preparation to replace |upload_url| of InitiateUpload methods in DriveServiceInterface by resource id. BUG=148632 TEST=Ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182144

Patch Set 1 : #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M chrome/browser/google_apis/gdata_wapi_url_generator.h View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_url_generator.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_url_generator_unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 10 months ago (2013-02-08 11:04:49 UTC) #1
kinaba
lgtm
7 years, 10 months ago (2013-02-08 11:08:04 UTC) #2
hashimoto
lgtm
7 years, 10 months ago (2013-02-08 11:44:36 UTC) #3
satorux1
LGTM
7 years, 10 months ago (2013-02-12 03:28:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12226073/9002
7 years, 10 months ago (2013-02-12 03:37:26 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98487
7 years, 10 months ago (2013-02-12 04:37:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12226073/9002
7 years, 10 months ago (2013-02-12 04:59:56 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98527
7 years, 10 months ago (2013-02-12 06:13:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12226073/9002
7 years, 10 months ago (2013-02-12 06:16:07 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98564
7 years, 10 months ago (2013-02-12 07:46:01 UTC) #10
satorux1
This should be safe to land after the branch cut.
7 years, 10 months ago (2013-02-12 09:41:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12226073/9002
7 years, 10 months ago (2013-02-12 13:09:07 UTC) #12
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98707
7 years, 10 months ago (2013-02-12 14:06:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12226073/9002
7 years, 10 months ago (2013-02-12 14:09:15 UTC) #14
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98737
7 years, 10 months ago (2013-02-12 15:05:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12226073/9002
7 years, 10 months ago (2013-02-13 02:58:25 UTC) #16
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 06:28:42 UTC) #17
Message was sent while issue was closed. 
Change committed as 182144

Powered by Google App Engine
This is Rietveld 408576698