Minimize PowerSaveBlocker usage during uploading data.

Minimize PowerSaveBlocker usage during uploading data.

Wait 30 secs before activating PowerSaveBlocker to dismiss small uploads.

BUG=173119
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182206

[hashimoto, 2013-02-05 10:07:40]

Darin,
Could you review this change?

[hashimoto, 2013-02-12 07:07:17]

On 2013/02/05 10:07:40, hashimoto wrote:
> Darin,
> Could you review this change?

ping?

[darin (slow to review), 2013-02-12 19:20:04]

https://codereview.chromium.org/12226005/diff/2001/content/browser/loader/pow...
File content/browser/loader/power_save_block_resource_throttle.cc (right):

https://codereview.chromium.org/12226005/diff/2001/content/browser/loader/pow...
content/browser/loader/power_save_block_resource_throttle.cc:20: class
PowerSaveBlockResourceThrottle::PowerSaveBlockerOwner {
I don't understand why you bothered to create this nested class.  You can just
fold this functionality into the PowerSaveBlockResourceThrottle class.

[hashimoto, 2013-02-13 08:02:35]

https://chromiumcodereview.appspot.com/12226005/diff/2001/content/browser/loa...
File content/browser/loader/power_save_block_resource_throttle.cc (right):

https://chromiumcodereview.appspot.com/12226005/diff/2001/content/browser/loa...
content/browser/loader/power_save_block_resource_throttle.cc:20: class
PowerSaveBlockResourceThrottle::PowerSaveBlockerOwner {
On 2013/02/12 19:20:05, darin wrote:
> I don't understand why you bothered to create this nested class.  You can just
> fold this functionality into the PowerSaveBlockResourceThrottle class.

I was trying to introduce more complicated mechanism like polling
URLRequest::GetUploadProgress(), and thought having a nested class was a good
way to handle canceling. (i.e. just calling scoped_ptr<>::reset is enough to
cancel all in-fly operations)

Abandoned this nested class since what the current patch does is simply delaying
power save block.

[darin (slow to review), 2013-02-13 08:23:49]

LGTM

That seems much simpler.

[commit-bot: I haz the power, 2013-02-13 08:39:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/12226005/9002

[commit-bot: I haz the power, 2013-02-13 13:24:02]

Change committed as 182206