Fix a bug where an extension's icon wasn't being properly reloaded if it changes

chrome/browser/resources/extensions/extension_list.js

Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index ddf6d215637018c9368dd0e2a307b7f06735f861..193521188d3a2c0e304b73390354c6832c2dbc80 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -35,6 +35,12 @@ cr.define('options', function() {
   ExtensionsList.prototype = {
     __proto__: HTMLDivElement.prototype,
 
+    /**
+     * @type {number} Appended to icon URL as a query string to prevent
+     * the icon from caching. Increments each time an extension is reloaded.
+     */
+    iconQueryId_: 0,
+
     /** @override */
     decorate: function() {
       this.textContent = '';
@@ -97,7 +103,8 @@ cr.define('options', function() {
         node.classList.add('extension-highlight');
 
       var item = node.querySelector('.extension-list-item');
-      item.style.backgroundImage = 'url(' + extension.icon + ')';
+      item.style.backgroundImage = 'url(' + extension.icon + '?' +
+                                   this.iconQueryId_++ + ')';

[not at google - send to devlin, 2013/02/13 01:59:31]

Ah I see - is the problem just that the background image isn't changing, so the
DOM doesn't know that it need to reload?

Would something like this work:

var iconUrl = 'url(' + extension.icon + ')';
if (iconUrl == item.style.backgroundImage)
  delete item.style.backgroundImage;
item.style.backgroundImage = iconUrl;

if not, something like

var iconUrl = 'url(' + extension.icon + ')';
if (iconUrl == item.style.backgroundImage) {
  delete item.style.backgroundImage;
  setTimeout(function() {
    item.style.backgroundImage = iconUrl;
  }, 0);
} else {
  item.style.backgroundImage = iconUrl;
}

etc...

[not at google - send to devlin, 2013/02/13 02:05:27]

Ok I straight away realised this was dumb, since the iconUrl isn't going to
change, that's the point. What I *mean't* was like

delete item.style.backgroundImage;
item.style.backgroundImage = '(' + extension.icon + ')';

or

delete item.style.backgroundImage;
setTimeout(function() {
  item.style.backgroundImage = '(' + extension.icon + ')';
}, 0);

[epeterson, 2013/02/14 01:09:23]

I've just tried these suggestions, and, unfortunately, neither of them appear to
be convincing the DOM that it needs to reload.

 
       var title = node.querySelector('.extension-title');
       title.textContent = extension.name;