Issue 12225122: Verifies WindowClosing() is invoked only once when a window is

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12225122: Verifies WindowClosing() is invoked only once when a window is (Closed)

Created:
7 years, 10 months ago by sky

Modified:
7 years, 10 months ago

Reviewers:
Elliot Glaysher, Ben Goodger (Google)

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Verifies WindowClosing() is invoked only once when a window is closed. Previously we were sending this out twice on aura, which was causing the task manager to CHECK. BUG=174512 TEST=covered by unit test R=ben@chromium.org,erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181810

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -1 line)			Patch
M	ui/views/widget/desktop_aura/desktop_native_widget_aura.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_root_window_host_linux.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/views/widget/widget_unittest.cc	View	1 chunk	+42 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/12225122/1

7 years, 10 months ago (2013-02-11 23:27:52 UTC) #3

Message was sent while issue was closed.

lgtm