Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12225101: Implement GetInitiateUpload{New,Existing}FileUrl on Drive API v2. (Closed)

Created:
7 years, 10 months ago by hidehiko
Modified:
7 years, 10 months ago
Reviewers:
hashimoto, satorux1, kinaba
CC:
chromium-reviews, achuith+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@b148632_replace_url_to_resource_id_2
Visibility:
Public.

Description

Implement GetInitiateUpload{New,Existing}FileUrl on Drive API v2. These methods will be used to implement InitiateUpload{New,Existing}Operation on Drive API v2. BUG=148632 TEST=Ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182215

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -0 lines) Patch
M chrome/browser/google_apis/drive_api_url_generator.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/drive_api_url_generator.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/drive_api_url_generator_unittest.cc View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
hidehiko
7 years, 10 months ago (2013-02-12 05:23:58 UTC) #1
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 10 months ago (2013-02-12 05:24:26 UTC) #2
kinaba
lgtm
7 years, 10 months ago (2013-02-12 05:55:28 UTC) #3
hashimoto
lgtm
7 years, 10 months ago (2013-02-12 07:12:02 UTC) #4
satorux1
This should be safe to land after the branch cut.
7 years, 10 months ago (2013-02-12 09:41:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12225101/1
7 years, 10 months ago (2013-02-12 13:08:53 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98706
7 years, 10 months ago (2013-02-12 14:01:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12225101/1
7 years, 10 months ago (2013-02-12 14:05:21 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98739
7 years, 10 months ago (2013-02-12 15:00:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12225101/1
7 years, 10 months ago (2013-02-13 02:57:57 UTC) #10
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=10085
7 years, 10 months ago (2013-02-13 12:17:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12225101/1
7 years, 10 months ago (2013-02-13 12:19:09 UTC) #12
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 14:36:23 UTC) #13
Message was sent while issue was closed. 
Change committed as 182215

Powered by Google App Engine
This is Rietveld 408576698