Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12225087: This adds the onNetworkChanged event to networkingPrivate (Closed)

Created:
7 years, 10 months ago by Greg Spencer (Chromium)
Modified:
7 years, 10 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, sail+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

This adds the onNetworkChanged event to networkingPrivate extension API. Trying to land this again after clang problem. Original review was here: https://chromiumcodereview.appspot.com/12188027/ (TBR'ing trivial change to profile_dependency_manager.cc) TBR=davemoore@chromium.org,kalman@chromium.org,pneubeck@chromium.org BUG=chromium:168713 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181892

Patch Set 1 #

Patch Set 2 : Upload after merge #

Patch Set 3 : disabling test temporarily #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -1 line) Patch
A chrome/browser/chromeos/extensions/networking_private_event_router.h View 1 1 chunk +54 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/extensions/networking_private_event_router.cc View 1 1 chunk +145 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/extensions/networking_private_event_router_factory.h View 1 chunk +50 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/extensions/networking_private_event_router_factory.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M chrome/browser/extensions/event_names.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/event_names.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/networking_private.json View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/12225087/2002
7 years, 10 months ago (2013-02-08 01:11:19 UTC) #1
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=82411
7 years, 10 months ago (2013-02-08 03:58:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/12225087/2002
7 years, 10 months ago (2013-02-08 17:43:53 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=82655
7 years, 10 months ago (2013-02-08 19:32:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/12225087/1015
7 years, 10 months ago (2013-02-11 21:38:19 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=110453
7 years, 10 months ago (2013-02-11 23:14:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/12225087/1015
7 years, 10 months ago (2013-02-12 00:46:49 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 06:55:10 UTC) #8
Message was sent while issue was closed. 
Change committed as 181892

Powered by Google App Engine
This is Rietveld 408576698