Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 12225081: ipc: Convert MessageLoop::RunUntilIdle() usage to base::RunLoop variant. (Closed)

Created:
7 years, 10 months ago by tfarina
Modified:
7 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

ipc: Convert MessageLoop::RunUntilIdle() usage to base::RunLoop variant. The former method is deprecated and actually it is just using RunLoop internally. The later is the cannonical method and should be used instead. BUG=131220 TEST=ipc_tests R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181539

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ipc/ipc_sync_channel_unittest.cc View 7 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
Hi Darin, could you review this to me? Thanks,
7 years, 10 months ago (2013-02-07 10:15:31 UTC) #1
darin (slow to review)
LGTM
7 years, 10 months ago (2013-02-07 22:20:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12225081/1
7 years, 10 months ago (2013-02-08 17:23:07 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-08 20:11:04 UTC) #4
Message was sent while issue was closed.
Change committed as 181539

Powered by Google App Engine
This is Rietveld 408576698