test/data/input/custom_radio_button_test.html - Issue 12225039: Support for observable models, fixes #259

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/data/input/custom_radio_button_test.html

Issue 12225039: Support for observable models, fixes #259 (Closed) Base URL: https://github.com/dart-lang/web-ui.git@master

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/data/input/custom_radio_button_test.html

diff --git a/test/data/input/custom_radio_button_test.html b/test/data/input/custom_radio_button_test.html

index 7f83cc66dc85cf4b5b71f9d3991d7dd38df1988a..46ef9acb969be884ad8d4b359918433d6144da1b 100644

--- a/test/data/input/custom_radio_button_test.html

+++ b/test/data/input/custom_radio_button_test.html

@@ -8,7 +8,6 @@ BSD-style license that can be found in the LICENSE file.

<head>

- <title>watch_global_var_test</title>

</head>

<body>

@@ -40,9 +39,9 @@ BSD-style license that can be found in the LICENSE file.

import 'package:web_ui/web_ui.dart';

import 'package:unittest/unittest.dart';

- var name = 'Bar';

- var foo = queryAll('input')[0];

- var bar = queryAll('input')[1];

+ @observable var name = 'Bar';

+ final foo = queryAll('input')[0];

+ final bar = queryAll('input')[1];

main() {

useShadowDom = false;

@@ -56,13 +55,13 @@ BSD-style license that can be found in the LICENSE file.

expect(name, 'Bar');

name = 'Nothing';

- dispatch();

+ deliverChangesSync();

expect(foo.checked, false, reason: 'nothing picked.');

expect(bar.checked, false, reason: 'nothing picked.');

expect(name, 'Nothing');

name = 'Foo';

- dispatch();

+ deliverChangesSync();

expect(foo.checked, true, reason: 'foo picked.');

expect(bar.checked, false, reason: 'foo picked.');

expect(name, 'Foo');

@@ -82,7 +81,7 @@ BSD-style license that can be found in the LICENSE file.

// It would be nice if this was "Foo".

expect(name, 'Bar', reason: 'DOM checked does not fire event.');

- window.setTimeout(() => window.postMessage('done', '*'), 0);

+ window.setImmediate(() => window.postMessage('done', '*'));

}, 0);

}

</script>

« no previous file with comments | « test/data/input/css_classes_binding_test.html ('k') | test/data/input/dir3/bootstrap_path_test_main.dart » ('j') | no next file with comments »