Change profile shortcut name format to "<username> - Chrome".

Change profile shortcut name format to "<username> - Chrome".

BUG=174168
TEST=Official builds create shortcuts in the above format.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180830

[sail, 2013-02-05 20:30:43]

https://codereview.chromium.org/12225011/diff/1/chrome/browser/profiles/profi...
File chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc (right):

https://codereview.chromium.org/12225011/diff/1/chrome/browser/profiles/profi...
chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc:288: #if
defined(GOOGLE_CHROME_BUILD)
I don't think this is a good idea. You should use the same constant that the
implementation uses (IDS_SHORT_PRODUCT_NAME or kBrowserAppName)

https://codereview.chromium.org/12225011/diff/1/chrome/browser/profiles/profi...
File chrome/browser/profiles/profile_shortcut_manager_win.cc (right):

https://codereview.chromium.org/12225011/diff/1/chrome/browser/profiles/profi...
chrome/browser/profiles/profile_shortcut_manager_win.cc:513:
shortcut_name.append(chrome::kBrowserAppName);
Weird, I've never seen this constant before.
In the UI code we always use IDS_SHORT_PRODUCT_NAME

[Alexei Svitkine (slow), 2013-02-05 20:56:00]

https://codereview.chromium.org/12225011/diff/1/chrome/browser/profiles/profi...
File chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc (right):

https://codereview.chromium.org/12225011/diff/1/chrome/browser/profiles/profi...
chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc:288: #if
defined(GOOGLE_CHROME_BUILD)
On 2013/02/05 20:30:43, sail wrote:
> I don't think this is a good idea. You should use the same constant that the
> implementation uses (IDS_SHORT_PRODUCT_NAME or kBrowserAppName)

Done.

https://codereview.chromium.org/12225011/diff/1/chrome/browser/profiles/profi...
File chrome/browser/profiles/profile_shortcut_manager_win.cc (right):

https://codereview.chromium.org/12225011/diff/1/chrome/browser/profiles/profi...
chrome/browser/profiles/profile_shortcut_manager_win.cc:513:
shortcut_name.append(chrome::kBrowserAppName);
On 2013/02/05 20:30:43, sail wrote:
> Weird, I've never seen this constant before.
> In the UI code we always use IDS_SHORT_PRODUCT_NAME

Done.

[sail, 2013-02-05 20:58:16]

LGTM!

[Alexei Svitkine (slow), 2013-02-05 20:59:29]

(I also sent a CL to kill kBrowserAppName here:
https://codereview.chromium.org/12225022/)

[commit-bot: I haz the power, 2013-02-05 21:02:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/12225011/12001

[commit-bot: I haz the power, 2013-02-05 23:46:22]

Change committed as 180830