Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 12224133: Move touch_selection_controller interface to ui/base. (Closed)

Created:
7 years, 10 months ago by varunjain
Modified:
7 years, 10 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Move touch_selection_controller interface to ui/base. I would also like to rename it to TouchEditingController since it is not just for selection. But that makes enough changes to the file to render git incapable of recognizing it as a move instead of a new file. So I will do the renaming in a separate CL. BUG=115237 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182139

Patch Set 1 #

Patch Set 2 : patch #

Total comments: 3

Patch Set 3 : patch #

Total comments: 2

Patch Set 4 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -132 lines) Patch
A + ui/base/touch/touch_editing_controller.h View 1 2 2 chunks +25 lines, -16 lines 0 comments Download
A + ui/base/touch/touch_editing_controller.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M ui/ui.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.h View 1 2 4 chunks +9 lines, -4 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 1 2 3 3 chunks +18 lines, -2 lines 0 comments Download
D ui/views/touchui/touch_selection_controller.h View 1 chunk +0 lines, -55 lines 0 comments Download
D ui/views/touchui/touch_selection_controller.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 1 2 6 chunks +32 lines, -32 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
varunjain
7 years, 10 months ago (2013-02-13 00:18:29 UTC) #1
varunjain
+sky for top level gyp changes.
7 years, 10 months ago (2013-02-13 00:25:11 UTC) #2
sadrul
LGTM, with one comment below. https://codereview.chromium.org/12224133/diff/2001/ui/base/touch/touch_editing_controller.h File ui/base/touch/touch_editing_controller.h (right): https://codereview.chromium.org/12224133/diff/2001/ui/base/touch/touch_editing_controller.h#newcode16 ui/base/touch/touch_editing_controller.h:16: class UI_EXPORT TouchSelectionClientView Is ...
7 years, 10 months ago (2013-02-13 00:26:56 UTC) #3
varunjain
https://codereview.chromium.org/12224133/diff/2001/ui/base/touch/touch_editing_controller.h File ui/base/touch/touch_editing_controller.h (right): https://codereview.chromium.org/12224133/diff/2001/ui/base/touch/touch_editing_controller.h#newcode16 ui/base/touch/touch_editing_controller.h:16: class UI_EXPORT TouchSelectionClientView On 2013/02/13 00:26:56, sadrul wrote: > ...
7 years, 10 months ago (2013-02-13 00:37:15 UTC) #4
sky
LGTM - feel free to TBR gyp changes
7 years, 10 months ago (2013-02-13 00:47:22 UTC) #5
sadrul
SLGTM https://codereview.chromium.org/12224133/diff/6001/ui/views/controls/textfield/native_textfield_views.cc File ui/views/controls/textfield/native_textfield_views.cc (right): https://codereview.chromium.org/12224133/diff/6001/ui/views/controls/textfield/native_textfield_views.cc#newcode331 ui/views/controls/textfield/native_textfield_views.cc:331: View::ConvertPointFromWidget(this, point); There is View::ConvertPointFromScreen
7 years, 10 months ago (2013-02-13 00:49:17 UTC) #6
varunjain
https://codereview.chromium.org/12224133/diff/2001/ui/base/touch/touch_editing_controller.h File ui/base/touch/touch_editing_controller.h (right): https://codereview.chromium.org/12224133/diff/2001/ui/base/touch/touch_editing_controller.h#newcode16 ui/base/touch/touch_editing_controller.h:16: class UI_EXPORT TouchSelectionClientView On 2013/02/13 00:37:15, varunjain wrote: > ...
7 years, 10 months ago (2013-02-13 00:52:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/12224133/9003
7 years, 10 months ago (2013-02-13 00:53:08 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 06:18:05 UTC) #9
Message was sent while issue was closed.
Change committed as 182139

Powered by Google App Engine
This is Rietveld 408576698