Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 12224113: [cc] Apply sublayer transform about anchor instead of about layer center. (Closed)

Created:
7 years, 10 months ago by shawnsingh
Modified:
7 years, 10 months ago
Reviewers:
danakj, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, Ian Vollick
Visibility:
Public.

Description

[cc] Apply sublayer transform about anchor instead of about layer center. There are some cases where WebCore internally needs to "reposition" the origin point about which CSS transforms are applied. For example, when a perspective container becomes composited, the composited location/bounds may change depending on the positioning of its children. The perspective-origin from the original DOM tree should not change, but internally it does require a new origin to be given to the compositor. It turns out that WebCore uses the anchor point layer property to communicate these cases. So, the compositor needs to apply the sublayer transform about the anchor point instead of about the layer center. BUG=157961 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181957

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed various sublayer comments in layer_tree_host_common #

Patch Set 3 : Fix windows build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -24 lines) Patch
M cc/layer_tree_host_common.cc View 1 4 chunks +7 lines, -9 lines 0 comments Download
M cc/layer_tree_host_common_unittest.cc View 1 2 6 chunks +34 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
shawnsingh
PTAL - thanks in advance.
7 years, 10 months ago (2013-02-12 00:53:43 UTC) #1
danakj
Assuming this doesn't break the web, the changes LGTM https://codereview.chromium.org/12224113/diff/1/cc/layer_tree_host_common.cc File cc/layer_tree_host_common.cc (right): https://codereview.chromium.org/12224113/diff/1/cc/layer_tree_host_common.cc#newcode870 cc/layer_tree_host_common.cc:870: ...
7 years, 10 months ago (2013-02-12 00:58:23 UTC) #2
shawnsingh
Comments fixed in latest patch. Manual testing of many 3d sites looks just fine. Unit ...
7 years, 10 months ago (2013-02-12 01:05:44 UTC) #3
enne (OOO)
lgtm2
7 years, 10 months ago (2013-02-12 01:07:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shawnsingh@chromium.org/12224113/4
7 years, 10 months ago (2013-02-12 16:53:29 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 18:31:23 UTC) #6
Message was sent while issue was closed.
Change committed as 181957

Powered by Google App Engine
This is Rietveld 408576698