Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: chrome/browser/ui/bookmarks/bookmark_prompt_controller.cc

Issue 12224093: Associate Google Update experiment IDs with the BookmarkPrompt trial. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Headers Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/metrics/variations/variation_ids.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/bookmarks/bookmark_prompt_controller.cc
diff --git a/chrome/browser/ui/bookmarks/bookmark_prompt_controller.cc b/chrome/browser/ui/bookmarks/bookmark_prompt_controller.cc
index 93a64c251be36ff9c6378528566512df19f78d13..3b8a7797f5258f4fcf71f9bff78ecd8273f708c2 100644
--- a/chrome/browser/ui/bookmarks/bookmark_prompt_controller.cc
+++ b/chrome/browser/ui/bookmarks/bookmark_prompt_controller.cc
@@ -21,6 +21,8 @@
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/chrome_version_info.h"
+#include "chrome/common/metrics/variations/variation_ids.h"
+#include "chrome/common/metrics/variations/variations_util.h"
#include "chrome/common/pref_names.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_types.h"
@@ -30,6 +32,11 @@ using content::WebContents;
namespace {
+const char kBookmarkPromptTrialName[] = "BookmarkPrompt";
+const char kBookmarkPromptDefaultGroup[] = "Disabled";
+const char kBookmarkPromptControlGroup[] = "Control";
+const char kBookmarkPromptExperimentGroup[] = "Experiment";
+
// This enum is used for the BookmarkPrompt.DisabledReason histogram.
enum PromptDisabledReason {
PROMPT_DISABLED_REASON_BY_IMPRESSION_COUNT,
@@ -211,7 +218,7 @@ bool BookmarkPromptController::IsEnabled() {
const std::string manual_group_name = base::FieldTrialList::FindFullName(
"BookmarkPrompt");
if (!manual_group_name.empty())
- return manual_group_name == "Experiment";
+ return manual_group_name == kBookmarkPromptExperimentGroup;
const ExperimentDateRange* date_range = GetExperimentDateRange();
if (!date_range)
@@ -219,13 +226,26 @@ bool BookmarkPromptController::IsEnabled() {
scoped_refptr<base::FieldTrial> trial(
base::FieldTrialList::FactoryGetFieldTrial(
- "BookmarkPrompt", 100, "Disabled",
+ kBookmarkPromptTrialName, 100, kBookmarkPromptDefaultGroup,
date_range->expiration_date.year,
date_range->expiration_date.month,
date_range->expiration_date.day_of_month, NULL));
trial->UseOneTimeRandomization();
- trial->AppendGroup("Control", 99);
- trial->AppendGroup("Experiment", 1);
+ trial->AppendGroup(kBookmarkPromptControlGroup, 99);
+ trial->AppendGroup(kBookmarkPromptExperimentGroup, 1);
+
+ chrome_variations::AssociateGoogleVariationID(
+ chrome_variations::GOOGLE_UPDATE_SERVICE,
+ kBookmarkPromptTrialName, kBookmarkPromptDefaultGroup,
+ chrome_variations::BOOKMARK_PROMPT_TRIAL_DEFAULT);
+ chrome_variations::AssociateGoogleVariationID(
+ chrome_variations::GOOGLE_UPDATE_SERVICE,
+ kBookmarkPromptTrialName, kBookmarkPromptControlGroup,
+ chrome_variations::BOOKMARK_PROMPT_TRIAL_CONTROL);
+ chrome_variations::AssociateGoogleVariationID(
+ chrome_variations::GOOGLE_UPDATE_SERVICE,
+ kBookmarkPromptTrialName, kBookmarkPromptExperimentGroup,
+ chrome_variations::BOOKMARK_PROMPT_TRIAL_EXPERIMENT);
const base::Time start_date = base::Time::FromLocalExploded(
date_range->install_date);
@@ -239,7 +259,7 @@ bool BookmarkPromptController::IsEnabled() {
trial->Disable();
return false;
}
- return trial->group_name() == "Experiment";
+ return trial->group_name() == kBookmarkPromptExperimentGroup;
}
void BookmarkPromptController::ActiveTabChanged(WebContents* old_contents,
« no previous file with comments | « no previous file | chrome/common/metrics/variations/variation_ids.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698