Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 12224093: Associate Google Update experiment IDs with the BookmarkPrompt trial. (Closed)

Created:
7 years, 10 months ago by SteveT
Modified:
7 years, 10 months ago
CC:
chromium-reviews, tfarina, MAD, Ilya Sherman, jar (doing other things)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Associate Google Update experiment IDs with the BookmarkPrompt trial. TEST=No user visible changes. BUG=169191 TBR=yosin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181889

Patch Set 1 #

Patch Set 2 : Headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M chrome/browser/ui/bookmarks/bookmark_prompt_controller.cc View 1 5 chunks +25 lines, -5 lines 0 comments Download
M chrome/common/metrics/variations/variation_ids.h View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
SteveT
PTAL. Scott: OWNERS review.
7 years, 10 months ago (2013-02-11 16:14:20 UTC) #1
sky
LGTM
7 years, 10 months ago (2013-02-11 21:18:39 UTC) #2
SteveT
R+asvitkine PTAL in Yoshifumi-san's absence.
7 years, 10 months ago (2013-02-12 01:47:18 UTC) #3
Alexei Svitkine (slow)
LGTM
7 years, 10 months ago (2013-02-12 01:53:44 UTC) #4
SteveT
Cool. Will commit this with Yoshifumi-san as TBR.
7 years, 10 months ago (2013-02-12 01:59:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/12224093/4
7 years, 10 months ago (2013-02-12 02:09:24 UTC) #6
yosin_UTC9
Sorry for late response. Could you tell me purpose of this path? Did I miss ...
7 years, 10 months ago (2013-02-12 02:23:04 UTC) #7
SteveT
On 2013/02/12 02:23:04, Yoshifumi Inoue wrote: > Sorry for late response. > Could you tell ...
7 years, 10 months ago (2013-02-12 02:26:16 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 06:45:44 UTC) #9
Message was sent while issue was closed.
Change committed as 181889

Powered by Google App Engine
This is Rietveld 408576698