Issue 12224078: SPDY - Added back code that deleted read_pending_. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(148)

My Issues | Starred Open | Closed | All

Issue 12224078: SPDY - Added back code that deleted read_pending_. (Closed)

Created:
7 years, 10 months ago by ramant (doing other things)

Modified:
7 years, 10 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

SPDY - Added back code that deleted read_pending_. R=rch@chromium.org BUG=175069 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181569

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	net/spdy/spdy_session.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	net/spdy/spdy_session.cc	View		5 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

Hi Ryan, Added back the code that got deleted (in last minute) in the previous ...

7 years, 10 months ago (2013-02-08 18:39:49 UTC) #1

Ryan Hamilton

Out of curiosity, why was this code removed? How does this fix the crash bug? ...

7 years, 10 months ago (2013-02-08 18:48:51 UTC) #2

Ryan Hamilton

lgtm to unblock while you investigate root causes.

7 years, 10 months ago (2013-02-08 19:37:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/12224078/2002

7 years, 10 months ago (2013-02-08 20:31:59 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/12224078/2002

7 years, 10 months ago (2013-02-08 21:47:58 UTC) #5

Message was sent while issue was closed.

Change committed as 181569

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698