Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 12223125: Delete Instant pyauto tests. (Closed)

Created:
7 years, 10 months ago by sreeram
Modified:
7 years, 10 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, melevin, samarth+watch_chromium.org, kkania, sreeram, gideonwald, dominich, anantha, robertshield, dyu1, dennis_jeffrey, David Black, Jered
Visibility:
Public.

Description

Delete Instant pyauto tests. Pyauto is deprecated. We'll add some of these tests back as browser tests. Some don't make sense because they are very specific to Google and not Chrome Instant generally (such as the case insensitivity test). We're not losing much test coverage here because many of these tests already exist as browser tests (e.g.: testing that Instant doesn't preview URLs, testing a non-Instant supporting engine). BUG=165843, 168809 R=phajdan.jr@chromium.org TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182319

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -323 lines) Patch
M chrome/browser/automation/testing_automation_provider.h View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 5 chunks +0 lines, -49 lines 0 comments Download
M chrome/test/functional/PYAUTO_TESTS View 4 chunks +0 lines, -7 lines 0 comments Download
D chrome/test/functional/instant.py View 1 chunk +0 lines, -211 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 2 chunks +0 lines, -45 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sreeram
7 years, 10 months ago (2013-02-13 03:23:45 UTC) #1
Paweł Hajdan Jr.
LGTM! Excellent, thank you.
7 years, 10 months ago (2013-02-13 13:25:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sreeram@chromium.org/12223125/1
7 years, 10 months ago (2013-02-13 17:41:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sreeram@chromium.org/12223125/1
7 years, 10 months ago (2013-02-13 19:36:47 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 22:10:41 UTC) #5
Message was sent while issue was closed.
Change committed as 182319

Powered by Google App Engine
This is Rietveld 408576698