When launching crosh process set TERM var to be 'xterm'

When launching crosh process set TERM var to be 'xterm'

Otherwise TERM will be set to 'linux' which could produce some control
sequences not supported by hterm (e.g. '\x1b]R')

BUG=chromium-os:38255
TEST=open crosh extension (ctrl-alt-T), enter shell: reset should not hang
TERM var should be set to xterm


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184004

[rginda, 2013-02-13 04:09:30]

lgtm after nit, thanks!

https://codereview.chromium.org/12223118/diff/1/chrome/browser/chromeos/proce...
File chrome/browser/chromeos/process_proxy/process_proxy.cc (right):

https://codereview.chromium.org/12223118/diff/1/chrome/browser/chromeos/proce...
chrome/browser/chromeos/process_proxy/process_proxy.cc:220:
environ.push_back(std::make_pair("TERM", "xterm"));
Could you set it to xterm-256color instead?  That's the default Secure Shell
uses too.

[tbarzic, 2013-02-13 04:17:23]

https://codereview.chromium.org/12223118/diff/1/chrome/browser/chromeos/proce...
File chrome/browser/chromeos/process_proxy/process_proxy.cc (right):

https://codereview.chromium.org/12223118/diff/1/chrome/browser/chromeos/proce...
chrome/browser/chromeos/process_proxy/process_proxy.cc:220:
environ.push_back(std::make_pair("TERM", "xterm"));
On 2013/02/13 04:09:30, rginda wrote:
> Could you set it to xterm-256color instead?  That's the default Secure Shell
> uses too.

I tried, but xterm-256color cannot be recognized (e.g. reset xter-256color fails
with "reset: unknown terminal type xterm-256color")

my guess is we're missing some package on ChromeOS..

[tbarzic, 2013-02-15 21:45:31]

On 2013/02/13 04:17:23, tbarzic wrote:
>
https://codereview.chromium.org/12223118/diff/1/chrome/browser/chromeos/proce...
> File chrome/browser/chromeos/process_proxy/process_proxy.cc (right):
> 
>
https://codereview.chromium.org/12223118/diff/1/chrome/browser/chromeos/proce...
> chrome/browser/chromeos/process_proxy/process_proxy.cc:220:
> environ.push_back(std::make_pair("TERM", "xterm"));
> On 2013/02/13 04:09:30, rginda wrote:
> > Could you set it to xterm-256color instead?  That's the default Secure Shell
> > uses too.
> 
> I tried, but xterm-256color cannot be recognized (e.g. reset xter-256color
fails
> with "reset: unknown terminal type xterm-256color")
> 
> my guess is we're missing some package on ChromeOS..

Robert, so are you fine with keeping xterm here (I don't think I'll be able to
look into why xterm-256color doesn't work in next week or two)

[rginda, 2013-02-15 21:49:56]

On 2013/02/15 21:45:31, tbarzic wrote:
> On 2013/02/13 04:17:23, tbarzic wrote:
> >
>
https://codereview.chromium.org/12223118/diff/1/chrome/browser/chromeos/proce...
> > File chrome/browser/chromeos/process_proxy/process_proxy.cc (right):
> > 
> >
>
https://codereview.chromium.org/12223118/diff/1/chrome/browser/chromeos/proce...
> > chrome/browser/chromeos/process_proxy/process_proxy.cc:220:
> > environ.push_back(std::make_pair("TERM", "xterm"));
> > On 2013/02/13 04:09:30, rginda wrote:
> > > Could you set it to xterm-256color instead?  That's the default Secure
Shell
> > > uses too.
> > 
> > I tried, but xterm-256color cannot be recognized (e.g. reset xter-256color
> fails
> > with "reset: unknown terminal type xterm-256color")
> > 
> > my guess is we're missing some package on ChromeOS..
> 
> Robert, so are you fine with keeping xterm here (I don't think I'll be able to
> look into why xterm-256color doesn't work in next week or two)

Yes, sorry, I missed your previous message.  I'm ok with "xterm".

[tbarzic, 2013-02-19 19:20:25]

+davemoore (as I need an owner approval for c/b/chromeos)

[commit-bot: I haz the power, 2013-02-22 01:32:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbarzic@chromium.org/12223118/8001

[commit-bot: I haz the power, 2013-02-22 03:47:51]

Change committed as 184004