sandbox/linux/seccomp-bpf/syscall_unittest.cc - Issue 12223109: SECCOMP-BPF: Refactor the BPF sandbox API to use fewer "static" fields and methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/seccomp-bpf/syscall_unittest.cc

Issue 12223109: SECCOMP-BPF: Refactor the BPF sandbox API to use fewer "static" fields and methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make sure unnamed namespaces are always top-level Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc ('K') | « sandbox/linux/seccomp-bpf/syscall_iterator.cc ('k') | sandbox/linux/seccomp-bpf/trap.h » ('j') | sandbox/linux/seccomp-bpf/util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sandbox/linux/seccomp-bpf/syscall_unittest.cc

diff --git a/sandbox/linux/seccomp-bpf/syscall_unittest.cc b/sandbox/linux/seccomp-bpf/syscall_unittest.cc

index 11fa315611293a58ec111f2122e68dd18f988923..136deb615cb514108d4e154f5e1c95cab5e7e0bd 100644

--- a/sandbox/linux/seccomp-bpf/syscall_unittest.cc

+++ b/sandbox/linux/seccomp-bpf/syscall_unittest.cc

@@ -78,12 +78,12 @@ intptr_t CopySyscallArgsToAux(const struct arch_seccomp_data& args, void *aux) {

return -ENOMEM;

}

-ErrorCode CopyAllArgsOnUnamePolicy(int sysno, void *aux) {

+ErrorCode CopyAllArgsOnUnamePolicy(Sandbox *sandbox, int sysno, void *aux) {

if (!Sandbox::IsValidSyscallNumber(sysno)) {

return ErrorCode(ENOSYS);

}

if (sysno == __NR_uname) {

- return Sandbox::Trap(CopySyscallArgsToAux, aux);

+ return sandbox->Trap(CopySyscallArgsToAux, aux);

} else {

return ErrorCode(ErrorCode::ERR_ALLOWED);

}