sandbox/linux/seccomp-bpf/errorcode_unittest.cc - Issue 12223109: SECCOMP-BPF: Refactor the BPF sandbox API to use fewer "static" fields and methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/seccomp-bpf/errorcode_unittest.cc

Issue 12223109: SECCOMP-BPF: Refactor the BPF sandbox API to use fewer "static" fields and methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make sure unnamed namespaces are always top-level Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/sandbox_seccomp_bpf_linux.cc ('K') | « sandbox/linux/seccomp-bpf/errorcode.cc ('k') | sandbox/linux/seccomp-bpf/linux_seccomp.h » ('j') | sandbox/linux/seccomp-bpf/sandbox_bpf.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sandbox/linux/seccomp-bpf/errorcode_unittest.cc

diff --git a/sandbox/linux/seccomp-bpf/errorcode_unittest.cc b/sandbox/linux/seccomp-bpf/errorcode_unittest.cc

index 21f889ee8839bacfe74a4892fa5fe06b89e397a1..10f21324593807bb1884f20bfff56dee6d6d1358 100644

--- a/sandbox/linux/seccomp-bpf/errorcode_unittest.cc

+++ b/sandbox/linux/seccomp-bpf/errorcode_unittest.cc

@@ -19,17 +19,19 @@ SANDBOX_TEST(ErrorCode, ErrnoConstructor) {

ErrorCode e2(EPERM);

SANDBOX_ASSERT(e2.err() == SECCOMP_RET_ERRNO + EPERM);

- ErrorCode e3 = Sandbox::Trap(NULL, NULL);

+ Sandbox sandbox;

+ ErrorCode e3 = sandbox.Trap(NULL, NULL);

SANDBOX_ASSERT((e3.err() & SECCOMP_RET_ACTION) == SECCOMP_RET_TRAP);

}

SANDBOX_TEST(ErrorCode, Trap) {

- ErrorCode e0 = Sandbox::Trap(NULL, "a");

- ErrorCode e1 = Sandbox::Trap(NULL, "b");

+ Sandbox sandbox;

+ ErrorCode e0 = sandbox.Trap(NULL, "a");

+ ErrorCode e1 = sandbox.Trap(NULL, "b");

SANDBOX_ASSERT((e0.err() & SECCOMP_RET_DATA) + 1 ==

(e1.err() & SECCOMP_RET_DATA));

- ErrorCode e2 = Sandbox::Trap(NULL, "a");

+ ErrorCode e2 = sandbox.Trap(NULL, "a");

SANDBOX_ASSERT((e0.err() & SECCOMP_RET_DATA) ==

(e2.err() & SECCOMP_RET_DATA));

}

@@ -44,9 +46,10 @@ SANDBOX_TEST(ErrorCode, Equals) {

ErrorCode e3(EPERM);

SANDBOX_ASSERT(!e1.Equals(e3));

- ErrorCode e4 = Sandbox::Trap(NULL, "a");

- ErrorCode e5 = Sandbox::Trap(NULL, "b");

- ErrorCode e6 = Sandbox::Trap(NULL, "a");

+ Sandbox sandbox;

+ ErrorCode e4 = sandbox.Trap(NULL, "a");

+ ErrorCode e5 = sandbox.Trap(NULL, "b");

+ ErrorCode e6 = sandbox.Trap(NULL, "a");

SANDBOX_ASSERT(!e1.Equals(e4));

SANDBOX_ASSERT(!e3.Equals(e4));

SANDBOX_ASSERT(!e5.Equals(e4));

@@ -64,9 +67,10 @@ SANDBOX_TEST(ErrorCode, LessThan) {

SANDBOX_ASSERT(!e1.LessThan(e3));

SANDBOX_ASSERT( e3.LessThan(e1));

- ErrorCode e4 = Sandbox::Trap(NULL, "a");

- ErrorCode e5 = Sandbox::Trap(NULL, "b");

- ErrorCode e6 = Sandbox::Trap(NULL, "a");

+ Sandbox sandbox;

+ ErrorCode e4 = sandbox.Trap(NULL, "a");

+ ErrorCode e5 = sandbox.Trap(NULL, "b");

+ ErrorCode e6 = sandbox.Trap(NULL, "a");

SANDBOX_ASSERT(e1.LessThan(e4));

SANDBOX_ASSERT(e3.LessThan(e4));

SANDBOX_ASSERT(e4.LessThan(e5));