Properly Remove Autofill Keyboard Listener.

chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
index 29ef75146505058e2c3d2a9d9d3b87650d2cd1a0..83259a2b8677a1754d7edb2e4d21ede943d8291d 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
@@ -104,7 +104,6 @@ AutofillPopupControllerImpl::AutofillPopupControllerImpl(
       selected_line_(kNoSelection),
       delete_icon_hovered_(false),
       is_hiding_(false),
-      inform_delegate_of_destruction_(true),
       weak_ptr_factory_(this) {
 #if !defined(OS_ANDROID)
   subtext_font_ = name_font_.DeriveFont(kLabelFontSizeDelta);
@@ -171,7 +170,6 @@ void AutofillPopupControllerImpl::Show(
 }
 
 void AutofillPopupControllerImpl::Hide() {
-  inform_delegate_of_destruction_ = false;
   HideInternal();

[Ilya Sherman, 2013/02/12 21:15:25]

nit: No longer a need for HideInternal() to be distinct from Hide(); let's
collapse those two methods down into just one.

[csharp, 2013/02/12 21:21:19]

Done.

 }
 
@@ -340,8 +338,7 @@ void AutofillPopupControllerImpl::HideInternal() {
 
   SetSelectedLine(kNoSelection);
 
-  if (inform_delegate_of_destruction_)
-    delegate_->OnPopupHidden(this);
+  delegate_->OnPopupHidden(this);
 
   if (view_)
     view_->Hide();