Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 12223106: Properly Remove Autofill Keyboard Listener. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index d6a5f498a82ac54bfc9bc3ce1de394d3bd40fe04..0be9f17e48d172f5cf75f701d05befcf94705637 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -1214,6 +1214,9 @@ void RenderWidgetHostImpl::AddKeyboardListener(KeyboardListener* listener) {
void RenderWidgetHostImpl::RemoveKeyboardListener(
KeyboardListener* listener) {
+ // Ensure that the element is actually in the list.
+ DCHECK(std::find(keyboard_listeners_.begin(), keyboard_listeners_.end(),
+ listener) != keyboard_listeners_.end());
keyboard_listeners_.remove(listener);
}

Powered by Google App Engine
This is Rietveld 408576698