Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2214)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.h

Issue 12223106: Properly Remove Autofill Keyboard Listener. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.h
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h b/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
index 1421a84b34ba0791d2149e56e7f9047bd2e152e5..e16ac31ba6708b831db9ae77f0e8adfbba06cf39 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
@@ -89,10 +89,6 @@ class AutofillPopupControllerImpl : public AutofillPopupController,
virtual int selected_line() const OVERRIDE;
virtual bool delete_icon_hovered() const OVERRIDE;
- // Like Hide(), but doesn't invalidate |delegate_| (the delegate will still
- // be informed of destruction).
- void HideInternal();
-
// Change which line is currently selected by the user.
void SetSelectedLine(int selected_line);
@@ -210,9 +206,6 @@ class AutofillPopupControllerImpl : public AutofillPopupController,
// True if |HideInternal| has already been called.
bool is_hiding_;
- // True if the delegate should be informed when |this| is destroyed.
- bool inform_delegate_of_destruction_;
-
base::WeakPtrFactory<AutofillPopupControllerImpl> weak_ptr_factory_;
};

Powered by Google App Engine
This is Rietveld 408576698