Issue 12223101: [Android] Cancel long press on ACTION_CANCEL as well

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12223101: [Android] Cancel long press on ACTION_CANCEL as well (Closed)

Created:
7 years, 10 months ago by boliu

Modified:
7 years, 10 months ago

Reviewers:
Ted C, Yusuf

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Cancel long press on ACTION_CANCEL as well Public documentation says CANCEL should be treated similarly to UP except it should not be peforming any of the actual actions. BUG= Android only change. Ran through android trybots. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182254

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -9 lines)			Patch
	M	content/public/android/java/src/org/chromium/content/browser/LongPressDetector.java	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	content/public/android/javatests/src/org/chromium/content/browser/LongPressDetectorTest.java	View		2 chunks	+24 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

boliu

This fixes internal bug 8148375 Will add owner after you think this looks good.

7 years, 10 months ago (2013-02-12 19:29:17 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/12223101/1

7 years, 10 months ago (2013-02-13 18:15:43 UTC) #5

Message was sent while issue was closed.

Change committed as 182254

Expand Messages | Collapse Messages