Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 12223093: [Android WebView] Add rules to bundle localised string paks. (Closed)

Created:
7 years, 10 months ago by benm (inactive)
Modified:
7 years, 10 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[Android WebView] Add rules to bundle localised string paks. Add makefile rules to install the built webkit string paks into the system image. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181976

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -1 line) Patch
M android_webview/Android.mk View 1 1 chunk +319 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
benm (inactive)
ptal. For reference: set of paks was generated with: find out/ -name "webkit_strings*.pak" | cut ...
7 years, 10 months ago (2013-02-12 13:58:48 UTC) #1
mnaganov (inactive)
https://codereview.chromium.org/12223093/diff/1/android_webview/Android.mk File android_webview/Android.mk (right): https://codereview.chromium.org/12223093/diff/1/android_webview/Android.mk#newcode77 android_webview/Android.mk:77: include $(CLEAR_VARS) Is it possible to somehow iterate over ...
7 years, 10 months ago (2013-02-12 14:05:49 UTC) #2
benm (inactive)
thanks mikhail! https://codereview.chromium.org/12223093/diff/1/android_webview/Android.mk File android_webview/Android.mk (right): https://codereview.chromium.org/12223093/diff/1/android_webview/Android.mk#newcode77 android_webview/Android.mk:77: include $(CLEAR_VARS) I don't think so, but ...
7 years, 10 months ago (2013-02-12 15:06:46 UTC) #3
mnaganov (inactive)
LGTM
7 years, 10 months ago (2013-02-12 15:10:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/12223093/7001
7 years, 10 months ago (2013-02-12 15:15:13 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98774
7 years, 10 months ago (2013-02-12 16:09:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/12223093/7001
7 years, 10 months ago (2013-02-12 16:13:58 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98835
7 years, 10 months ago (2013-02-12 18:19:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/12223093/7001
7 years, 10 months ago (2013-02-12 18:23:54 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 19:29:19 UTC) #10
Message was sent while issue was closed.
Change committed as 181976

Powered by Google App Engine
This is Rietveld 408576698