Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 12223088: Sync FileSystem: Update metadata database even when the file is not modified. (Closed)

Created:
7 years, 10 months ago by tzik
Modified:
7 years, 10 months ago
Reviewers:
kinuko, nhiroki
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

Sync FileSystem: Update metadata database even when the file is not modified. For current impl, Resource ID of a file is not updated for this sequence: (1) Add a file with resource_id_1 -- wait for synced -- (2) Delete the file (3) Add a file with resource_id_2, and same content with the first file. If the (2) and (3) come together, (2) is squashed into (3). And then (3) becomes nop since the content is not modified. As the result, the metadata of the file has wrong Resource ID and all other change is ignored. (notry, since most of try jobs are passed, and failed try looks not related to the patch) BUG=175667 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/sync_file_system/drive_file_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tzik
PTAL
7 years, 10 months ago (2013-02-12 11:47:55 UTC) #1
nhiroki
LGTM, thank you for working on this! This patch works fine in my local environment.
7 years, 10 months ago (2013-02-12 11:54:49 UTC) #2
kinuko
the description sgtm
7 years, 10 months ago (2013-02-12 11:58:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/12223088/1
7 years, 10 months ago (2013-02-12 12:17:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/12223088/1
7 years, 10 months ago (2013-02-13 12:12:59 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 13:14:44 UTC) #6
Message was sent while issue was closed.
Change committed as 182204

Powered by Google App Engine
This is Rietveld 408576698