Issue 12223086: Update app runtime custom bindings to handle no WebIntents launch data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12223086: Update app runtime custom bindings to handle no WebIntents launch data. (Closed)

Created:
7 years, 10 months ago by benwells

Modified:
7 years, 10 months ago

Reviewers:
jeremya

CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, Nico

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update app runtime custom bindings to handle no WebIntents launch data. Launch data for apps no longer includes intents. This removes the custom bindings code to translate the intent data, and also re-enables some tests which were disabled. BUG=175534 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182120

Patch Set 1 #

Patch Set 2 : More stuff removed #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -176 lines)			Patch
M	chrome/browser/extensions/platform_app_browsertest.cc	View		2 chunks	+3 lines, -7 lines	0 comments	Download
M	chrome/renderer/resources/extensions/app_runtime_custom_bindings.js	View	1	3 chunks	+3 lines, -71 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/webintent_handler/background.js	View	1	1 chunk	+0 lines, -33 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/webintent_handler/manifest.json	View	1	1 chunk	+0 lines, -23 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/get_display_path/test.js	View	1	1 chunk	+6 lines, -10 lines	0 comments	Download
D	chrome/test/data/extensions/platform_apps/launch_reply/manifest.json	View	1	1 chunk	+0 lines, -17 lines	0 comments	Download
D	chrome/test/data/extensions/platform_apps/launch_reply/test.js	View	1	1 chunk	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/12223086/2001

7 years, 10 months ago (2013-02-12 23:45:49 UTC) #3

Message was sent while issue was closed.

Change committed as 182120

Expand Messages | Collapse Messages