Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Issue 12223084: Fix crash around Reset function call. (Closed)

Created:
7 years, 10 months ago by Seigo Nonaka
Modified:
7 years, 10 months ago
Reviewers:
satorux1
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Fix crash around Reset function call. There is timing issue around initialization, if the InputContext is initialized after InputMethodManager, Reset function will be called with NULL object proxy. This cause a crash. If the object proxy is not ready, calling Reset is not necessary. So just doing nothing is fine. BUG=174248 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182147

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/chromeos/input_method/ibus_controller_impl.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Seigo Nonaka
7 years, 10 months ago (2013-02-12 04:52:46 UTC) #1
satorux1
LGTM with a request: https://codereview.chromium.org/12223084/diff/1/chrome/browser/chromeos/input_method/ibus_controller_impl.cc File chrome/browser/chromeos/input_method/ibus_controller_impl.cc (right): https://codereview.chromium.org/12223084/diff/1/chrome/browser/chromeos/input_method/ibus_controller_impl.cc#newcode249 chrome/browser/chromeos/input_method/ibus_controller_impl.cc:249: if (client && client->IsObjectProxyReady()) please ...
7 years, 10 months ago (2013-02-13 01:07:43 UTC) #2
Seigo Nonaka
Thank you for your review. Submitting... https://codereview.chromium.org/12223084/diff/1/chrome/browser/chromeos/input_method/ibus_controller_impl.cc File chrome/browser/chromeos/input_method/ibus_controller_impl.cc (right): https://codereview.chromium.org/12223084/diff/1/chrome/browser/chromeos/input_method/ibus_controller_impl.cc#newcode249 chrome/browser/chromeos/input_method/ibus_controller_impl.cc:249: if (client && ...
7 years, 10 months ago (2013-02-13 01:17:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12223084/5001
7 years, 10 months ago (2013-02-13 01:22:56 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 06:40:20 UTC) #5
Message was sent while issue was closed.
Change committed as 182147

Powered by Google App Engine
This is Rietveld 408576698