Issue 12223044: Don't accidentally propagate Omaha variable to child processes.

Issue 12223044: Don't accidentally propagate Omaha variable to child processes. (Closed)

Created:
7 years, 10 months ago by erikwright (departed)

Modified:
7 years, 10 months ago

Reviewers:
brettw

CC:
chromium-reviews, grt+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't accidentally propagate Omaha variable to child processes. Short term fix to issue 174203 (when Chrome is launched by Omaha post-install, it fails when attempting to install the App Launcher). Should be reverted when issue 174953 is fixed and widely deployed. R=brettw BUG=174203, 174953 TEST=SET GoogleUpdateIsMachine=1 and then launch chrome.exe. Using procexp, verify that the environment variable is not present in the running process. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181394

Patch Set 1 #

Patch Set 2 : Move from chrome_constants to env_vars. #

Patch Set 3 : Fix a silly mistake. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -9 lines)			Patch
M	chrome/app/client_util.cc	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/common/env_vars.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/common/env_vars.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/installer/util/master_preferences.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/installer/util/util_constants.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/installer/util/util_constants.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/12223044/3001

7 years, 10 months ago (2013-02-07 20:58:39 UTC) #3

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 10 months ago (2013-02-07 22:08:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/12223044/10

7 years, 10 months ago (2013-02-07 23:01:51 UTC) #5

Message was sent while issue was closed.

Change committed as 181394

Expand Messages | Collapse Messages