Issue 12223011: Added more default expectations to MockDBusThreadManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12223011: Added more default expectations to MockDBusThreadManager. (Closed)

Created:
7 years, 10 months ago by Joao da Silva

Modified:
7 years, 10 months ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Added more default expectations to MockDBusThreadManager. This prevents a lot of warnings when using a MockDBusThreadManager in a browser_test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180967

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -2 lines)			Patch
	M	chromeos/dbus/cryptohome_client.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	chromeos/dbus/mock_dbus_thread_manager.cc	View	1	4 chunks	+22 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Joao da Silva

Hi Satoru, can you have a look at this change? I'm not sure this is ...

7 years, 10 months ago (2013-02-05 22:21:10 UTC) #1

satorux1

LGTM. In retrospect, use of GMock for the D-Bus code was questionable, but this is ...

7 years, 10 months ago (2013-02-06 03:13:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/12223011/3001

7 years, 10 months ago (2013-02-06 06:57:26 UTC) #3

Message was sent while issue was closed.

Change committed as 180967