Rebase ConfirmBubbleViews on DialogDelegateView.

Rebase ConfirmBubbleViews on DialogDelegateView.

This fixes the dialog-like confirm "bubble" class.
(make it a window-modal dialog delegate subclass)
Call new SpellingBubbleModel::SetPref(false) on 'No thanks'.
(clicking ok then cancel in two windows yields feature off)

See pics of the change at http://crbug.com/166075#c31

TODO(followup): Remove ConfirmBubble*? (only used by spelling).
TODO(followup): Fix insets after tweaking the new dialog style.
TODO(followup): Fix dialog 'extra view' placement.

BUG=166075
TEST=Spelling bubble (web textfield context menu -> "Spell-checker options" -> "Ask Google for suggestions") looks/works reasonable on Win/CrOS/Aura.
R=rlp@chromium.org,sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181975

[msw, 2013-02-12 00:04:19]

Hey Rachel and Scott, please take a look; thanks!

[rpetterson, 2013-02-12 00:27:51]

On 2013/02/12 00:04:19, msw wrote:
> Hey Rachel and Scott, please take a look; thanks!

From a spelling standpoint, LGTM.

[rpetterson, 2013-02-12 00:28:19]

Oh, and one small question.

https://codereview.chromium.org/12222003/diff/1007/chrome/browser/ui/views/co...
File chrome/browser/ui/views/confirm_bubble_views_unittest.cc (right):

https://codereview.chromium.org/12222003/diff/1007/chrome/browser/ui/views/co...
chrome/browser/ui/views/confirm_bubble_views_unittest.cc:31:
views::DialogDelegateView::CreateDialogWidget(bubble, NULL, parent)->Show();
You don't need any checks about placement here?

[msw, 2013-02-12 00:40:12]

https://codereview.chromium.org/12222003/diff/1007/chrome/browser/ui/views/co...
File chrome/browser/ui/views/confirm_bubble_views_unittest.cc (right):

https://codereview.chromium.org/12222003/diff/1007/chrome/browser/ui/views/co...
chrome/browser/ui/views/confirm_bubble_views_unittest.cc:31:
views::DialogDelegateView::CreateDialogWidget(bubble, NULL, parent)->Show();
On 2013/02/12 00:28:20, rpetterson wrote:
> You don't need any checks about placement here?

There is no anchor view/point to check since it's no longer a bubble. Dialogs
are roughly centered on the parent window, but when this gets converted to a
constrained window, it'll be placed like:
https://docs.google.com/a/google.com/folder/d/0B6x6iYCtKinEUTFOWUJFTWJFSTA/ed...

This subclass probably doesn't need special testing for its inherited placement
behavior, which the constrained window code ought to check. I added Mike Wittman
to the review in case he has any thoughts on this.

[Mike Wittman, 2013-02-12 00:49:57]

https://codereview.chromium.org/12222003/diff/1007/chrome/browser/ui/views/co...
File chrome/browser/ui/views/confirm_bubble_views_unittest.cc (right):

https://codereview.chromium.org/12222003/diff/1007/chrome/browser/ui/views/co...
chrome/browser/ui/views/confirm_bubble_views_unittest.cc:31:
views::DialogDelegateView::CreateDialogWidget(bubble, NULL, parent)->Show();
On 2013/02/12 00:40:12, msw wrote:
> On 2013/02/12 00:28:20, rpetterson wrote:
> > You don't need any checks about placement here?
> 
> There is no anchor view/point to check since it's no longer a bubble. Dialogs
> are roughly centered on the parent window, but when this gets converted to a
> constrained window, it'll be placed like:
>
https://docs.google.com/a/google.com/folder/d/0B6x6iYCtKinEUTFOWUJFTWJFSTA/ed...
> 
> This subclass probably doesn't need special testing for its inherited
placement
> behavior, which the constrained window code ought to check. I added Mike
Wittman
> to the review in case he has any thoughts on this.

Ultimately tab-constrained dialog positioning will be handled within the new
WebContentsModalDialogManager, so there shouldn't be any need to test
positioning at the individual dialog level.

[sky, 2013-02-12 03:15:37]

LGTM

[commit-bot: I haz the power, 2013-02-12 03:18:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/12222003/1007

[commit-bot: I haz the power, 2013-02-12 06:17:18]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-02-12 06:28:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/12222003/1007

[commit-bot: I haz the power, 2013-02-12 16:12:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/12222003/16002

[commit-bot: I haz the power, 2013-02-12 17:27:41]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-02-12 17:57:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/12222003/16002

[commit-bot: I haz the power, 2013-02-12 19:29:04]

Change committed as 181975