Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 12221153: Fix regression caused by crrev.com/181782. The expected continue URL has (Closed)

Created:
7 years, 10 months ago by Roger Tawa OOO till Jul 10th
Modified:
7 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix regression caused by crrev.com/181782. The expected continue URL has changed and sync setup handler needs to handle the new one. BUG=175672 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182342

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Roger Tawa OOO till Jul 10th
Hi Hui, Can you please take a look? This is a regression caused by crrev.com/181782. ...
7 years, 10 months ago (2013-02-12 22:34:40 UTC) #1
guohui
On 2013/02/12 22:34:40, Roger Tawa wrote: > Hi Hui, > > Can you please take ...
7 years, 10 months ago (2013-02-12 22:57:47 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 10 months ago (2013-02-13 01:29:14 UTC) #3
Roger Tawa OOO till Jul 10th
Hi Drew, Can you take a look? Thanks.
7 years, 10 months ago (2013-02-13 01:48:02 UTC) #4
Andrew T Wilson (Slow)
lgtm
7 years, 10 months ago (2013-02-13 07:43:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/12221153/7001
7 years, 10 months ago (2013-02-13 15:08:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/12221153/7001
7 years, 10 months ago (2013-02-13 19:36:05 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 23:57:25 UTC) #8
Message was sent while issue was closed.
Change committed as 182342

Powered by Google App Engine
This is Rietveld 408576698