Fix compile breakage when using stream operators when NOTIMPLEMENTED_POLICY=5.

Fix compile breakage when using stream operators when NOTIMPLEMENTED_POLICY=5.

In logging.h, the NOTIMPLEMENTED_POLICY macro defines the behavior of the NOTIMPLEMENTED() macro.  For case 5 (log only once per call-site), code that uses stream output operators would fail to compile.  For example, in ui/aura/root_window_host_linux.cc:747:

  NOTIMPLEMENTED() << "Unsupported bits-per-pixel " << image->bits_per_pixel;

The solution is to add EAT_STREAM_PARAMETERS to the end of the definition in base/logging.h.  This will log call sites as "not implemented" but will not log the additional custom messages.

TEST=Compiled chrome with compiler define set to NOTIMPLEMENTED_POLICY=5 and ran to confirm desired NOTIMPLEMENTED() behaviors.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182167

[miu, 2013-02-12 22:04:29]

jar: Need you to review one-liner base/logging.h change.

Thanks,
Yuri

[jar (doing other things), 2013-02-13 01:49:40]

LGTM  (with nit below)

https://codereview.chromium.org/12221152/diff/1/base/logging.h
File base/logging.h (right):

https://codereview.chromium.org/12221152/diff/1/base/logging.h#newcode983
base/logging.h:983: static int count = 0;\
nit: how about changing this to:

static bool ran_once = false;

[miu, 2013-02-13 03:50:23]

On 2013/02/13 01:49:40, jar wrote:
> nit: how about changing this to:
> 
> static bool ran_once = false;

Done.

Thanks for the review!  :)

[commit-bot: I haz the power, 2013-02-13 03:52:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/12221152/5001

[commit-bot: I haz the power, 2013-02-13 08:32:15]

Change committed as 182167