Issue 12221147: Extend the translate prefs interface with new methods to clear/check blacklisted sites/languages

Issue 12221147: Extend the translate prefs interface with new methods to clear/check blacklisted sites/languages (Closed)

Created:
7 years, 10 months ago by Miguel Garcia

Modified:
7 years, 10 months ago

Reviewers:
MAD

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Extend the translate prefs interface with new methods to clear/check blacklisted sites/languages Add const to some the retrieve methods. BUG=149349 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182220

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -15 lines)			Patch
	M	chrome/browser/translate/translate_prefs.h	View	1	3 chunks	+18 lines, -9 lines	0 comments	Download
	M	chrome/browser/translate/translate_prefs.cc	View		7 chunks	+28 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

MAD

LGTM with small nits... Thanks! BYE MAD https://codereview.chromium.org/12221147/diff/1/chrome/browser/translate/translate_prefs.h File chrome/browser/translate/translate_prefs.h (right): https://codereview.chromium.org/12221147/diff/1/chrome/browser/translate/translate_prefs.h#newcode45 chrome/browser/translate/translate_prefs.h:45: // Will ...

7 years, 10 months ago (2013-02-12 20:42:42 UTC) #1

Miguel Garcia

Thanks for the quick review! https://codereview.chromium.org/12221147/diff/1/chrome/browser/translate/translate_prefs.h File chrome/browser/translate/translate_prefs.h (right): https://codereview.chromium.org/12221147/diff/1/chrome/browser/translate/translate_prefs.h#newcode45 chrome/browser/translate/translate_prefs.h:45: // Will return true ...

7 years, 10 months ago (2013-02-13 09:31:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/12221147/7001

7 years, 10 months ago (2013-02-13 09:33:20 UTC) #3

Message was sent while issue was closed.

Change committed as 182220

Expand Messages | Collapse Messages