Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 12221143: Set default control on Terms of Service screen (Closed)

Created:
7 years, 10 months ago by bartfab (slow)
Modified:
7 years, 10 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Set default control on Terms of Service screen This CL addresses the a11y issue that the Terms of Service screen does not have any focused control by default. The focus is now placed on the back button by default and shifts to the accept button when the Terms of Service have finished loading. BUG=175730 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182096

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M chrome/browser/resources/chromeos/login/login.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.js View 3 chunks +27 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
bartfab (slow)
Hi Nikita, Could you take a look please?
7 years, 10 months ago (2013-02-12 15:21:24 UTC) #1
Nikita (slow)
lgtm https://chromiumcodereview.appspot.com/12221143/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.js File chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.js (right): https://chromiumcodereview.appspot.com/12221143/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.js#newcode52 chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.js:52: if (!$('tos-back-button').blurred) nit: You could check what's the ...
7 years, 10 months ago (2013-02-12 20:51:48 UTC) #2
bartfab (slow)
https://chromiumcodereview.appspot.com/12221143/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.js File chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.js (right): https://chromiumcodereview.appspot.com/12221143/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.js#newcode52 chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.js:52: if (!$('tos-back-button').blurred) On 2013/02/12 20:51:48, Nikita Kostylev wrote: > ...
7 years, 10 months ago (2013-02-12 23:22:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/12221143/1
7 years, 10 months ago (2013-02-12 23:27:06 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 02:41:44 UTC) #5
Message was sent while issue was closed.
Change committed as 182096

Powered by Google App Engine
This is Rietveld 408576698