Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 12221126: Minor fix on message center footer. (Closed)

Created:
7 years, 10 months ago by Jun Mukai
Modified:
7 years, 10 months ago
Reviewers:
miket_OOO, dharcourt
CC:
chromium-reviews
Visibility:
Public.

Description

Minor fix on message center footer. 1. Add a border bar to the top of the footer button area. 2. Change the inset size of the footer and scroll_content. The existing code scrolls the contents right after the button content, but a buffer is necessary. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ui/message_center/message_center_bubble.cc View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jun Mukai
7 years, 10 months ago (2013-02-11 22:56:59 UTC) #1
dharcourt
lgtm
7 years, 10 months ago (2013-02-12 02:31:47 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 10 months ago (2013-02-12 03:28:08 UTC) #3
Jun Mukai
miket, can you review this? I'm asking some guys why CQ still thinks Charles isn't ...
7 years, 10 months ago (2013-02-12 17:37:52 UTC) #4
miket_OOO
lgtm
7 years, 10 months ago (2013-02-13 00:20:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/12221126/1
7 years, 10 months ago (2013-02-13 00:46:11 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 08:32:02 UTC) #7
Message was sent while issue was closed.
Change committed as 182166

Powered by Google App Engine
This is Rietveld 408576698