Custom implementation of VectorPlatformDeviceEmf::drawBitmapRect, to shield it from changes in SkDe…

Custom implementation of VectorPlatformDeviceEmf::drawBitmapRect, to shield it from changes in SkDevice::drawBitmapRect

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181955

[edisonn, 2013-02-11 15:50:13]

Steve, do you think I need to put this in SkPdfDevice too?

[vandebo (ex-Chrome), 2013-02-11 22:45:43]

LGTM

[edisonn, 2013-02-12 01:43:46]

could you check in this change? both my client seems to be read only only
somehow.


On Mon, Feb 11, 2013 at 5:45 PM, <vandebo@chromium.org> wrote:

> LGTM
>
>
https://codereview.chromium.**org/12221116/<https://codereview.chromium.org/1...
>

[vandebo (ex-Chrome), 2013-02-12 01:47:07]

Still LGTM (for CQ's benefit)

We prefer using the commit queue, which is triggered by clicking the Commit
check box, which I've done.

On 2013/02/12 01:43:46, edisonn wrote:
> could you check in this change? both my client seems to be read only only
> somehow.
> 
> 
> On Mon, Feb 11, 2013 at 5:45 PM, <mailto:vandebo@chromium.org> wrote:
> 
> > LGTM
> >
> >
>
https://codereview.chromium.**org/12221116/%3Chttps://codereview.chromium.org...>
> >

[commit-bot: I haz the power, 2013-02-12 01:51:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/edisonn@google.com/12221116/14001

[commit-bot: I haz the power, 2013-02-12 04:26:06]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[edisonn, 2013-02-12 11:48:29]

this change should not affect mac, it is a windows only change


On Mon, Feb 11, 2013 at 11:26 PM, <commit-bot@chromium.org> wrote:

> Retried try job too often on mac_rel for step(s) browser_tests
> http://build.chromium.org/p/**tryserver.chromium/**
>
buildstatus?builder=mac_rel&**number=98465<http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98465>
>
>
https://chromiumcodereview.**appspot.com/12221116/<https://chromiumcodereview...
>

[commit-bot: I haz the power, 2013-02-12 12:22:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/edisonn@google.com/12221116/14001

[edisonn, 2013-02-12 12:24:20]

On 2013/02/12 11:48:29, edisonn wrote:
> this change should not affect mac, it is a windows only change
> 
> 
> On Mon, Feb 11, 2013 at 11:26 PM, <mailto:commit-bot@chromium.org> wrote:
> 
> > Retried try job too often on mac_rel for step(s) browser_tests
> > http://build.chromium.org/p/**tryserver.chromium/**
> >
>
buildstatus?builder=mac_rel&**number=98465<http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98465>
> >
> >
>
https://chromiumcodereview.**appspot.com/12221116/%3Chttps://chromiumcoderevi...>
> >

linux_cromeos issue not related either (TabCaptureApiTest.EndToEnd)

[commit-bot: I haz the power, 2013-02-12 14:49:22]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-02-12 17:53:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/edisonn@google.com/12221116/14001

[commit-bot: I haz the power, 2013-02-12 18:26:17]

Change committed as 181955