Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: media/video/capture/screen/mac/desktop_configuration.h

Issue 12221103: Fix ScreenCapturerMac handling of secondary configurations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update comments. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/capture/screen/mac/desktop_configuration.h
diff --git a/media/video/capture/screen/mac/desktop_configuration.h b/media/video/capture/screen/mac/desktop_configuration.h
index c3c65b39be54a5d7daf613ad0a8f738e7275beb4..b17d3bf123f01b4b6681451bb58e9f1656aa85f8 100644
--- a/media/video/capture/screen/mac/desktop_configuration.h
+++ b/media/video/capture/screen/mac/desktop_configuration.h
@@ -20,10 +20,6 @@ namespace media {
struct MEDIA_EXPORT MacDisplayConfiguration {
MacDisplayConfiguration();
- // Returns the current configuration of the specified display.
- MEDIA_EXPORT static MacDisplayConfiguration ForDisplay(
- CGDirectDisplayID display_id);
-
// Cocoa identifier for this display.
CGDirectDisplayID id;
@@ -44,8 +40,10 @@ struct MEDIA_EXPORT MacDesktopConfiguration {
MacDesktopConfiguration();
~MacDesktopConfiguration();
- // Returns the current configuration of the desktop.
- MEDIA_EXPORT static MacDesktopConfiguration GetCurrent();
+ // Returns the desktop & display configurations in Cartesian (bottom-left
+ // origin) or inverse-Cartesian (top-left origin) coordinates.
+ enum Origin { BottomLeftOrigin, TopLeftOrigin };
+ MEDIA_EXPORT static MacDesktopConfiguration GetCurrent(Origin origin);
Sergey Ulanov 2013/02/11 22:57:20 Not sure if we need |origin| - this function is al
Wez 2013/02/11 23:14:45 Mac's Cocoa uses Cartesian (bottom-left), so I cou
// Bounds of the desktop in Density-Independent Pixels (DIPs).
SkIRect bounds;

Powered by Google App Engine
This is Rietveld 408576698