Calling IBusBridge::Initialize/Shutdown function.

Calling IBusBridge::Initialize/Shutdown function.

Initialize/Shutdown IBusBridge on input method initialization/shutting down.

IBusBridge is only used for ChromeOS-Chrome on Desktop Linux.

BUG=170671
TEST=try bots.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182098

[satorux1, 2013-02-07 01:46:16]

https://codereview.chromium.org/12221045/diff/1/chrome/browser/chromeos/input...
File chrome/browser/chromeos/input_method/input_method_configuration.cc (right):

https://codereview.chromium.org/12221045/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/input_method_configuration.cc:36: if
(!base::chromeos::IsRunningOnChromeOS())
Please add a comment why !IsRunningOnChromeOS()

https://codereview.chromium.org/12221045/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/input_method_configuration.cc:67: if
(!base::chromeos::IsRunningOnChromeOS())
This looks rather fragile.

Can you do something like:

  if (ibus bridge exists)
    IBusBridge::Shutdown();

[Seigo Nonaka, 2013-02-08 07:53:01]

https://codereview.chromium.org/12221045/diff/1/chrome/browser/chromeos/input...
File chrome/browser/chromeos/input_method/input_method_configuration.cc (right):

https://codereview.chromium.org/12221045/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/input_method_configuration.cc:36: if
(!base::chromeos::IsRunningOnChromeOS())
On 2013/02/07 01:46:16, satorux1 wrote:
> Please add a comment why !IsRunningOnChromeOS()

Done.

https://codereview.chromium.org/12221045/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/input_method_configuration.cc:67: if
(!base::chromeos::IsRunningOnChromeOS())
On 2013/02/07 01:46:16, satorux1 wrote:
> This looks rather fragile.
> 
> Can you do something like:
> 
>   if (ibus bridge exists)
>     IBusBridge::Shutdown();

Done.

[satorux1, 2013-02-12 03:26:52]

LGTM

https://codereview.chromium.org/12221045/diff/5001/chrome/browser/chromeos/in...
File chrome/browser/chromeos/input_method/input_method_configuration.cc (right):

https://codereview.chromium.org/12221045/diff/5001/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/input_method_configuration.cc:39: //
TODO(nona): Remove this condition when ibus-daemon is gone.
Add a crbug.com/ URL?

[Seigo Nonaka, 2013-02-12 13:44:55]

Thank you.
Submitting...

https://codereview.chromium.org/12221045/diff/5001/chrome/browser/chromeos/in...
File chrome/browser/chromeos/input_method/input_method_configuration.cc (right):

https://codereview.chromium.org/12221045/diff/5001/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/input_method_configuration.cc:39: //
TODO(nona): Remove this condition when ibus-daemon is gone.
On 2013/02/12 03:26:53, satorux1 wrote:
> Add a crbug.com/ URL?

Done.

[commit-bot: I haz the power, 2013-02-12 13:45:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/12221045/7002

[commit-bot: I haz the power, 2013-02-12 14:38:45]

Retried try job too often on linux_chromeos for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-02-12 15:01:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/12221045/4004

[commit-bot: I haz the power, 2013-02-12 15:58:50]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-02-13 00:35:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/12221045/4004

[commit-bot: I haz the power, 2013-02-13 02:54:59]

Change committed as 182098