Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1222103005: Only initialize NSS in PpapiPluginMain on !USE_OPENSSL builds. (Closed)

Created:
5 years, 5 months ago by davidben
Modified:
5 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@init-nss-safely
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only initialize NSS in PpapiPluginMain on !USE_OPENSSL builds. This dates to https://chromiumcodereview.appspot.com/11411013 which was added to resolve the ClearKey CDM. ClearKey uses routines from //crypto which may use NSS. But it doesn't need NSS in the chimera build, so we should limit this to !USE_OPENSSL builds. (The tests in question have also since moved to browser_tests and out of //content.) BUG=506323 Committed: https://crrev.com/5b8de7cab29ba996a03d2862b59e3a4dc9e6559e Cr-Commit-Position: refs/heads/master@{#337935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/ppapi_plugin/ppapi_plugin_main.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
davidben
5 years, 5 months ago (2015-07-06 23:41:45 UTC) #2
Jorge Lucangeli Obes
lgtm
5 years, 5 months ago (2015-07-07 03:51:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222103005/1
5 years, 5 months ago (2015-07-08 22:17:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-08 23:02:50 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 23:03:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b8de7cab29ba996a03d2862b59e3a4dc9e6559e
Cr-Commit-Position: refs/heads/master@{#337935}

Powered by Google App Engine
This is Rietveld 408576698