Issue 12220139: find_bar: Convert a bunch of string constants to char array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12220139: find_bar: Convert a bunch of string constants to char array. (Closed)

Created:
7 years, 10 months ago by tfarina

Modified:
7 years, 10 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

find_bar: Convert a bunch of string constants to char array. And put them in unnamed namespace. TEST=browser_tests TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182146

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -18 lines)			Patch
	M	chrome/browser/ui/find_bar/find_bar_host_browsertest.cc	View		2 chunks	+18 lines, -18 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12220139/1

7 years, 10 months ago (2013-02-13 00:16:05 UTC) #2

Message was sent while issue was closed.

lgtm