Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: cc/picture_layer_impl.cc

Issue 12220133: cc: Stretch textures by .5 texels to prevent out of bounds sampling (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix cc_unittests Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/picture_layer_impl_unittest.cc » ('j') | cc/picture_layer_tiling.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/picture_layer_impl.cc
diff --git a/cc/picture_layer_impl.cc b/cc/picture_layer_impl.cc
index bb608e84e00d27661ac0bb86599db4f79981bbca..0af1913bbbf817f7c492928fa2a69f1fcb6bdf6e 100644
--- a/cc/picture_layer_impl.cc
+++ b/cc/picture_layer_impl.cc
@@ -96,11 +96,17 @@ void PictureLayerImpl::appendQuads(QuadSink& quadSink,
bool isAxisAlignedInTarget = !clipped && target_quad.IsRectilinear();
bool useAA = !isAxisAlignedInTarget;
+ bool isPixelAligned = isAxisAlignedInTarget && drawTransform().IsIdentityOrIntegerTranslation();
brianderson 2013/02/13 00:10:19 Note: the logic here reflects the logic used to de
+ PictureLayerTiling::LayerDeviceAlignment layerDeviceAlignment =
+ isPixelAligned ? PictureLayerTiling::LayerAlignedToDevice
+ : PictureLayerTiling::LayerNotAlignedToDevice;
+
if (showDebugBorders()) {
for (PictureLayerTilingSet::Iterator iter(tilings_.get(),
contentsScaleX(),
rect,
- ideal_contents_scale_);
+ ideal_contents_scale_,
+ layerDeviceAlignment);
iter;
++iter) {
SkColor color;
@@ -139,7 +145,8 @@ void PictureLayerImpl::appendQuads(QuadSink& quadSink,
for (PictureLayerTilingSet::Iterator iter(tilings_.get(),
contentsScaleX(),
rect,
- ideal_contents_scale_);
+ ideal_contents_scale_,
+ layerDeviceAlignment);
iter;
++iter) {
ResourceProvider::ResourceId resource = 0;
@@ -426,7 +433,8 @@ ResourceProvider::ResourceId PictureLayerImpl::contentsResourceId() const {
for (PictureLayerTilingSet::Iterator iter(tilings_.get(),
scale,
content_rect,
- ideal_contents_scale_);
+ ideal_contents_scale_,
+ PictureLayerTiling::LayerDeviceAlignmentUnknown);
iter;
++iter) {
// Mask resource not ready yet.
@@ -474,7 +482,8 @@ bool PictureLayerImpl::areVisibleResourcesReady() const {
for (PictureLayerTiling::Iterator iter(tiling,
contentsScaleX(),
- rect);
+ rect,
+ PictureLayerTiling::LayerDeviceAlignmentUnknown);
iter;
++iter) {
// A null tile (i.e. no recording) is considered "ready".
« no previous file with comments | « no previous file | cc/picture_layer_impl_unittest.cc » ('j') | cc/picture_layer_tiling.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698