Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 12220133: cc: Stretch textures by .5 texels to prevent out of bounds sampling (Closed)

Created:
7 years, 10 months ago by brianderson
Modified:
7 years, 10 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, piman, epenner, klobag.chromium, Sami, nduca
Visibility:
Public.

Description

cc: Stretch textures by .5 texels to prevent out of bounds sampling This will allow us to revert texture clamping logic that reduces the fill rate on some devices. Instead of requiring us to clamp texture sampling, this patch stretches textures by .5 texels past quad bounds to avoid blending in invalid texels when GL_LINEAR filtering is used. BUG=173480 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182116

Patch Set 1 #

Patch Set 2 : Fix cc_unittests #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -23 lines) Patch
M cc/picture_layer_impl.cc View 4 chunks +13 lines, -4 lines 1 comment Download
M cc/picture_layer_impl_unittest.cc View 1 4 chunks +8 lines, -4 lines 0 comments Download
M cc/picture_layer_tiling.h View 2 chunks +9 lines, -3 lines 0 comments Download
M cc/picture_layer_tiling.cc View 3 chunks +19 lines, -2 lines 1 comment Download
M cc/picture_layer_tiling_set.h View 2 chunks +4 lines, -3 lines 0 comments Download
M cc/picture_layer_tiling_set.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M cc/picture_layer_tiling_set_unittest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M cc/picture_layer_tiling_unittest.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brianderson
https://codereview.chromium.org/12220133/diff/2015/cc/picture_layer_impl.cc File cc/picture_layer_impl.cc (right): https://codereview.chromium.org/12220133/diff/2015/cc/picture_layer_impl.cc#newcode99 cc/picture_layer_impl.cc:99: bool isPixelAligned = isAxisAlignedInTarget && drawTransform().IsIdentityOrIntegerTranslation(); Note: the logic ...
7 years, 10 months ago (2013-02-13 00:10:19 UTC) #1
enne (OOO)
lgtm
7 years, 10 months ago (2013-02-13 00:22:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/12220133/2015
7 years, 10 months ago (2013-02-13 00:29:48 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 04:31:18 UTC) #4
Message was sent while issue was closed.
Change committed as 182116

Powered by Google App Engine
This is Rietveld 408576698