Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 12220130: i18n for placeholders in requestAutocomplete dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/autofill/autofill_dialog_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index de646bdb57565d5dbc45e7c6293391c37f5406be..f2ebb10b06cfd55a4ba830238cb09f1d4fe8a44f 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -167,32 +167,43 @@ void AutofillDialogControllerImpl::Show() {
}
const DetailInput kEmailInputs[] = {
- { 1, EMAIL_ADDRESS, "Email address" },
+ { 1, EMAIL_ADDRESS, IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL },
};
const DetailInput kCCInputs[] = {
- { 2, CREDIT_CARD_NUMBER, "Card number" },
+ { 2, CREDIT_CARD_NUMBER, IDS_AUTOFILL_DIALOG_PLACEHOLDER_CARD_NUMBER },
{ 3, CREDIT_CARD_EXP_MONTH },
{ 3, CREDIT_CARD_EXP_4_DIGIT_YEAR },
- { 3, CREDIT_CARD_VERIFICATION_CODE, "CVC" },
- { 4, CREDIT_CARD_NAME, "Cardholder name" },
+ { 3, CREDIT_CARD_VERIFICATION_CODE, IDS_AUTOFILL_DIALOG_PLACEHOLDER_CVC },
+ { 4, CREDIT_CARD_NAME, IDS_AUTOFILL_DIALOG_PLACEHOLDER_CARDHOLDER_NAME },
};
const DetailInput kBillingInputs[] = {
- { 5, ADDRESS_HOME_LINE1, "Street address", "billing" },
- { 6, ADDRESS_HOME_LINE2, "Street address (optional)", "billing" },
- { 7, ADDRESS_HOME_CITY, "City", "billing" },
- { 8, ADDRESS_HOME_STATE, "State", "billing" },
- { 8, ADDRESS_HOME_ZIP, "ZIP code", "billing", 0.5 },
+ { 5, ADDRESS_HOME_LINE1, IDS_AUTOFILL_DIALOG_PLACEHOLDER_ADDRESS_LINE_1,
+ "billing" },
+ { 6, ADDRESS_HOME_LINE2, IDS_AUTOFILL_DIALOG_PLACEHOLDER_ADDRESS_LINE_2,
+ "billing" },
+ { 7, ADDRESS_HOME_CITY, IDS_AUTOFILL_DIALOG_PLACEHOLDER_LOCALITY,
+ "billing" },
+ // TODO(estade): state is supposed to be a combobox.
+ { 8, ADDRESS_HOME_STATE, IDS_AUTOFILL_FIELD_LABEL_STATE, "billing" },
+ { 8, ADDRESS_HOME_ZIP, IDS_AUTOFILL_DIALOG_PLACEHOLDER_POSTAL_CODE,
+ "billing", 0.5 },
};
const DetailInput kShippingInputs[] = {
- { 9, NAME_FULL, "Full name", "shipping" },
- { 10, ADDRESS_HOME_LINE1, "Street address", "shipping" },
- { 11, ADDRESS_HOME_LINE2, "Street address (optional)", "shipping" },
- { 12, ADDRESS_HOME_CITY, "City", "shipping" },
- { 13, ADDRESS_HOME_STATE, "State", "shipping" },
- { 13, ADDRESS_HOME_ZIP, "ZIP code", "shipping", 0.5 },
+ { 9, NAME_FULL, IDS_AUTOFILL_DIALOG_PLACEHOLDER_ADDRESSEE_NAME,
+ "shipping" },
+ { 10, ADDRESS_HOME_LINE1, IDS_AUTOFILL_DIALOG_PLACEHOLDER_ADDRESS_LINE_1,
+ "shipping" },
+ { 11, ADDRESS_HOME_LINE2, IDS_AUTOFILL_DIALOG_PLACEHOLDER_ADDRESS_LINE_2,
+ "shipping" },
+ { 12, ADDRESS_HOME_CITY, IDS_AUTOFILL_DIALOG_PLACEHOLDER_LOCALITY,
+ "shipping" },
+ // TODO(estade): state is supposed to be a combobox.
+ { 13, ADDRESS_HOME_STATE, IDS_AUTOFILL_FIELD_LABEL_STATE, "shipping" },
+ { 13, ADDRESS_HOME_ZIP, IDS_AUTOFILL_DIALOG_PLACEHOLDER_POSTAL_CODE,
+ "shipping", 0.5 },
};
FilterInputs(form_structure_,
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/autofill/autofill_dialog_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698