Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12220130: i18n for placeholders in requestAutocomplete dialog (Closed)

Created:
7 years, 10 months ago by Evan Stade
Modified:
7 years, 10 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, Raman Kakilate, tfarina, benquan, dhollowa+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

i18n for placeholders in requestAutocomplete dialog BUG=157270 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182354

Patch Set 1 #

Total comments: 1

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -18 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 1 chunk +26 lines, -15 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_types.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Evan Stade
7 years, 10 months ago (2013-02-12 21:27:28 UTC) #1
Dan Beam
lgtm https://codereview.chromium.org/12220130/diff/1/chrome/browser/ui/autofill/autofill_dialog_types.h File chrome/browser/ui/autofill/autofill_dialog_types.h (right): https://codereview.chromium.org/12220130/diff/1/chrome/browser/ui/autofill/autofill_dialog_types.h#newcode30 chrome/browser/ui/autofill/autofill_dialog_types.h:30: // in the row should be allotted to ...
7 years, 10 months ago (2013-02-12 22:31:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/12220130/1
7 years, 10 months ago (2013-02-12 22:36:24 UTC) #3
commit-bot: I haz the power
Presubmit check for 12220130-1 failed and returned exit status 1. INFO:root:Found 4 file(s). Running presubmit ...
7 years, 10 months ago (2013-02-12 22:36:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/12220130/1
7 years, 10 months ago (2013-02-13 00:25:32 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=111100
7 years, 10 months ago (2013-02-13 02:41:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/12220130/8002
7 years, 10 months ago (2013-02-13 03:42:24 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=111152
7 years, 10 months ago (2013-02-13 05:01:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/12220130/8002
7 years, 10 months ago (2013-02-13 16:45:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/12220130/8002
7 years, 10 months ago (2013-02-13 19:35:18 UTC) #10
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 00:46:34 UTC) #11
Message was sent while issue was closed. 
Change committed as 182354

Powered by Google App Engine
This is Rietveld 408576698