Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1544)

Issue 12220115: [cc] Dont throw away tiles that stop moving (Closed)

Created:
7 years, 10 months ago by nduca
Modified:
7 years, 10 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

[cc] Dont throw away tiles that stop moving The check being removed here basically says "if you're offscreen, and have no time to visible, then you should go in the never bin." The problem is that when a layer stops moving, then its offscreen tiles are put in never bin. That means that we lose all those tiles we put effort into painting. This increases the frequency at which one sees blurry tiles after the page goes stationary. R=ccameron,reveman BUG=175276 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181974

Patch Set 1 #

Total comments: 1

Patch Set 2 : Just the important part #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M cc/tile_manager.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nduca
7 years, 10 months ago (2013-02-12 05:03:48 UTC) #1
ccameron
lgtm, mod skipping the other part of the diff for now. https://codereview.chromium.org/12220115/diff/1/cc/tile_manager.cc File cc/tile_manager.cc (right): ...
7 years, 10 months ago (2013-02-12 05:05:36 UTC) #2
enne (OOO)
Come on, you can make a better CL description than this. Also, bug number?
7 years, 10 months ago (2013-02-12 05:07:33 UTC) #3
nduca
Okay try this on for size.
7 years, 10 months ago (2013-02-12 05:12:54 UTC) #4
enne (OOO)
On 2013/02/12 05:12:54, nduca wrote: > Okay try this on for size. Thanks, that makes ...
7 years, 10 months ago (2013-02-12 05:20:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/12220115/8001
7 years, 10 months ago (2013-02-12 05:39:54 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98567
7 years, 10 months ago (2013-02-12 08:28:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/12220115/8001
7 years, 10 months ago (2013-02-12 18:19:49 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 19:28:50 UTC) #9
Message was sent while issue was closed.
Change committed as 181974

Powered by Google App Engine
This is Rietveld 408576698