Next phase for chrome.networkingPrivate interface.

chromeos/dbus/shill_service_client.cc

Index: chromeos/dbus/shill_service_client.cc
diff --git a/chromeos/dbus/shill_service_client.cc b/chromeos/dbus/shill_service_client.cc
index efc92436204b29a5911fb252a9b3ab9bd2d3dcb4..ec48be4a59aced5566962d65cc1e1a59ad03fa3d 100644
--- a/chromeos/dbus/shill_service_client.cc
+++ b/chromeos/dbus/shill_service_client.cc
@@ -9,6 +9,8 @@
 #include "base/message_loop.h"
 #include "base/stl_util.h"
 #include "base/values.h"
+#include "chromeos/dbus/dbus_thread_manager.h"
+#include "chromeos/dbus/shill_manager_client.h"
 #include "chromeos/dbus/shill_property_changed_observer.h"
 #include "dbus/bus.h"
 #include "dbus/message.h"
@@ -247,6 +249,18 @@ class ShillServiceClientStubImpl : public ShillServiceClient,
       error_callback.Run("StubError", "Service not found");
       return;
     }
+    if (name == flimflam::kStateProperty) {
+      // If we connect to a service, then we move it to the top of the list in
+      // the manager client.
+      std::string state;
+      if (value.GetAsString(&state) && state == flimflam::kStateOnline) {
+        ShillManagerClient* manager_client =
+            DBusThreadManager::Get()->GetShillManagerClient();
+        manager_client->GetTestInterface()->RemoveService(service_path.value());
+        manager_client->GetTestInterface()->AddServiceAtIndex(
+            service_path.value(), 0, true);

[stevenjb, 2013/02/12 17:19:16]

I'd like to avoid cross dependencies between these client stubs, or at least
talk through how we want these stubs to evolve before adding more complex
behaviors like this.

[Greg Spencer (Chromium), 2013/02/12 17:34:56]

OK, but the reason for this is that I'm unable to test the network list change
event without connect or disconnect affecting it, since those are the only
methods I have so far to change state (and when we run with Shill, connecting
does change the order).

+      }
+    }
     dict->SetWithoutPathExpansion(name, value.DeepCopy());
     MessageLoop::current()->PostTask(
         FROM_HERE,