Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 12220109: Fix a bug where chrome.runtime.getBackgroundPage would return null if the event (Closed)

Created:
7 years, 10 months ago by Matt Perry
Modified:
7 years, 10 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Fix a bug where chrome.runtime.getBackgroundPage would return null if the event page has started but hasn't finished loading. BUG=175116 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181868

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M chrome/browser/extensions/api/runtime/runtime_api.cc View 1 chunk +9 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Matt Perry
Adding an api_test would be easy enough, but they are heavyweight and I figured this ...
7 years, 10 months ago (2013-02-11 23:56:30 UTC) #1
Yoyo Zhou
LGTM
7 years, 10 months ago (2013-02-12 00:49:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/12220109/1
7 years, 10 months ago (2013-02-12 01:00:02 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 05:17:30 UTC) #4
Message was sent while issue was closed.
Change committed as 181868

Powered by Google App Engine
This is Rietveld 408576698