Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 12220107: Base: account for calloc aborting in security unittests (Closed)

Created:
7 years, 10 months ago by jln (very slow on Chromium)
Modified:
7 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Base: account for calloc aborting in security unittests On Linux, when not using tcmalloc, we still have a small wrapper that aborts when allocation functions OOM. In that configuration, we now We consider it a successful detection of an overflow condition if the process aborts. BUG=175500 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182628

Patch Set 1 #

Patch Set 2 : Test for GTEST_HAS_DEATH_TEST. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -32 lines) Patch
M base/security_unittest.cc View 1 8 chunks +47 lines, -32 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jln (very slow on Chromium)
This should fix the issue in your configuration.
7 years, 10 months ago (2013-02-11 23:38:37 UTC) #1
jln (very slow on Chromium)
Since I'm pretty sure David will be happy with it, adding Willchan for owner approval ...
7 years, 10 months ago (2013-02-12 02:38:28 UTC) #2
digit
lgtm. Thanks Julien, I confirm that this fixes base_unittests for the linux_redux build!
7 years, 10 months ago (2013-02-12 09:31:29 UTC) #3
digit1
friendly ping?
7 years, 10 months ago (2013-02-13 16:33:18 UTC) #4
willchan no longer on Chromium
Sorry, I've been OOO with a fever. I took a look earlier but all the ...
7 years, 10 months ago (2013-02-13 18:00:16 UTC) #5
jln (very slow on Chromium)
Jim, I tried to spare you on this one, but it failed :) Could you ...
7 years, 10 months ago (2013-02-13 18:42:30 UTC) #6
jar (doing other things)
lgtm
7 years, 10 months ago (2013-02-15 00:23:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/12220107/5001
7 years, 10 months ago (2013-02-15 00:59:11 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-02-15 06:10:41 UTC) #9
Message was sent while issue was closed.
Change committed as 182628

Powered by Google App Engine
This is Rietveld 408576698